This repository was archived by the owner on Mar 7, 2026. It is now read-only.
feat: search result autoscroll - #515
Open
weilirs wants to merge 4 commits into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements an autoscroll feature for search results, allowing users to jump directly to relevant content positions when selecting search results.
- Added position tracking in
chunking.tswith new functions that maintain character positions in the original document - Extended the database schema in
schema.tswith an optionalstartPosfield to store chunk positions - Modified
DBResultPreviewandDBSearchPreviewcomponents to pass position information when results are clicked - Implemented scrolling logic in
FileContext.tsxthat intelligently finds the best DOM element to scroll to - Added proper error handling with fallbacks when ideal scroll targets can't be found
Greptile AI
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+104
to
+109
| const chunkPosition = stringInfo.text.indexOf(chunkText, currentOffset) | ||
|
|
||
| if (chunkPosition !== -1) { | ||
| const absolutePosition = stringInfo.pos + chunkPosition | ||
|
|
||
| currentOffset = chunkPosition + 1 |
There was a problem hiding this comment.
logic: The currentOffset = chunkPosition + 1 logic might skip content if there are overlapping chunks with identical text. Consider using currentOffset = chunkPosition + chunkText.length to ensure proper progression through the text.
Suggested change
| const chunkPosition = stringInfo.text.indexOf(chunkText, currentOffset) | |
| if (chunkPosition !== -1) { | |
| const absolutePosition = stringInfo.pos + chunkPosition | |
| currentOffset = chunkPosition + 1 | |
| const chunkPosition = stringInfo.text.indexOf(chunkText, currentOffset) | |
| if (chunkPosition !== -1) { | |
| const absolutePosition = stringInfo.pos + chunkPosition | |
| currentOffset = chunkPosition + chunkText.length |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.